✅ Deploy Preview for selenium-dev canceled.

PR Reviewer Guide 🔍

Here are some key observations to aid the review process:

var stringWriter = new StringWriter();
var originalOutput = Console.Error;
Console.SetError(stringWriter);

driver = new ChromeDriver();

using (var ctx = Log.CreateContext(LogEventLevel.Debug).Handlers.Add(new ConsoleLogHandler()))
{
    // logs will be emitted to STDERR
    driver.Url = "https://www.selenium.dev/selenium/web/blank.html";
}

Assert.IsTrue(stringWriter.ToString().Contains("get {\"url\":\"https://www.selenium.dev/selenium/web/blank.html\"}"));
Console.SetError(originalOutput);
stringWriter.Dispose();

PR Code Suggestions ✨

Explore these optional code suggestions:

+            try
+            {
+                using (var ctx = Log.CreateContext(LogEventLevel.Debug).Handlers.Add(new ConsoleLogHandler()))
+                {
+                    // logs will be emitted to STDERR
+                    _driver = new InternetExplorerDriver();
+                }
 
-            using (var ctx = Log.CreateContext(LogEventLevel.Debug).Handlers.Add(new ConsoleLogHandler()))
+                Assert.IsTrue(stringWriter.ToString().Contains("Executing command: []: newSession"));
+            }
+            finally
             {
-                // logs will be emitted to STDERR
-                _driver = new InternetExplorerDriver();
+                Console.SetError(originalOutput);
+                stringWriter.Dispose();
             }

-var stringWriter = new StringWriter();
-var originalOutput = Console.Error;
-Console.SetError(stringWriter);
+using (var stringWriter = new StringWriter())
+{
+    var originalOutput = Console.Error;
+    Console.SetError(stringWriter);
 
-using (var ctx = Log.CreateContext(LogEventLevel.Debug).Handlers.Add(new ConsoleLogHandler()))
-{
-    // logs will be emitted to STDERR
-    _driver = new InternetExplorerDriver();
+    using (var ctx = Log.CreateContext(LogEventLevel.Debug).Handlers.Add(new ConsoleLogHandler()))
+    {
+        // logs will be emitted to STDERR
+        _driver = new InternetExplorerDriver();
+    }
+
+    Assert.IsTrue(stringWriter.ToString().Contains("Executing command: []: newSession"));
+    Console.SetError(originalOutput);
 }
 
-Assert.IsTrue(stringWriter.ToString().Contains("Executing command: []: newSession"));
-Console.SetError(originalOutput);
-stringWriter.Dispose();
-

The other code examples seem to refer to having the DriverService perform the desired operation (logging to console, logging to file, etc).

Let me know if this is the right mechanism to advertise to users and @nvborisenko if this is the right thing for users to do here

@RenderMichael No, it is incorrect.

Current behavior: when we start geckodriver.exe it outputs messages into user's console (STDOUT?). Depending on log level, nothing common with our internal logging mechanism. Some users don't like that using selenium library implicitly puts something to their console application (I remember at least 2 issues, please search it). Personally I also don't like it. There is only one workaround: configure log level to see nothing in console, or configure geckodriver.exe to put logs into file. No more ways.

Now, when we have internal logging, it might be beneficial to catch all messages from geckodriver.exe and route it to our internal logging. So user will not see strange messages in his console, only if he explicitly says he wants it.

I believe these changes are already present in the codebase.